[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130105121903.OR11T.689655.root@eastrmwml105>
Date: Sat, 5 Jan 2013 12:19:03 -0500
From: <jfoug@....net>
To: john-dev@...ts.openwall.com
Subject: Re: Trying to build john without *_fmt_plug.c
here is a patch that removes any plug dependencies. That is if you manually rename NT_fmt_plug.c to NT_fmt.c and gost_plug.c to gost.c. NOTE, I did not look at uaf2john depending upon uaf_encode_plug.c, since I have moved that fully out of my test environment, due to it being 100% not buildable under VC.
The dependancies for netlm and nethalflm were fixed by doing strcmp against the formats label. The media wiki 'function' is not used by mediawiki format. it is a simple helper function. I moved it out of the plugin format. It was only added, due to the salt fixup being kind of nasty, since it is variable length. It was needed in loader and cracker, so I made a function for it. It seemed 'right' to put it into the format file, but that makes this a non-plug format. I simply moved it to cracker.
NT I am pretty sure is easiest to simply make a non-plug. Since it is tied into the asm stuff, breaking it out is non trivial. NT2 can still be a plug. Only 1 has to be non-plug.
as has been mentioned, there ARE coupling between some plug files themselves. However, if the user is removing plug files, they will have to address these themselves.
I have also included one VC specific tweak to BLAKE2, to get things to compile (inline is not usable in c, _inline must be used). That code is already in #ifdef MSCVER so will not impact anything else.
---- Frank Dittrich <frank_dittrich@...mail.com> wrote:
> On 01/05/2013 05:28 PM, jfoug@....net wrote:
> >
> > ---- magnum <john.magnum@...hmail.com> wrote:
> >> BTW you could remove non-format *_plug.c as well:
> >
> > gost_plug.c is NOT a plug. It should never have been done that way. It should be renamed gost.c and put gost.o into Makefile.
>
> Yes. gost_fmt_plug.c is used at least by gost_fmt_plug.c and by
> dynamic_fmt.c.
>
> uaf_encode_plug.c is needed for uaf2john.
>
> The other *_plug can only be removed if the *_fmt_plug.c files which
> need them are removed as well, so I wouldn't encourage users to remove
> these.
>
> blake2b-ref_plug.c currently is only needed by rawBLAKE2_512_fmt_plug.c.
> KRB4_std_plug.c is needed by KRB4_fmt_plug.c.
> KRB5_std_plug.c is needed by KRB5_fmt_plug.c.
>
> Frank
Download attachment "JTR-Plug-Decouple.diff" of type "application/octet-stream" (4627 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
