[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABob6iqLGdV9ZZXuiy89UPJv0bi=SLqfr3B6TksW5Pcp7SFb7Q@mail.gmail.com>
Date: Mon, 31 Dec 2012 19:35:39 +0100
From: Lukas Odzioba <lukas.odzioba@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Rejecting hashes in valid() due to memory allocation failures?
2012/12/31 Lukas Odzioba <lukas.odzioba@...il.com>:
> 2012/12/31 Lukas Odzioba <lukas.odzioba@...il.com>:
>> 2012/12/30 magnum <john.magnum@...hmail.com>:
>>> If/when we search & replace these, we should check for ones that should be replaced with mem_alloc_tiny() instead (in particular, ones that lack a corresponding free()).
>>
>> I am a volunteer to do that.
>
> In opencl_zip_fmt.c (and some others) I see that inbuffer and
> outbuffer are alocated by malloc(), but cracked is alocated by
> mem_calloc_tiny().
>
> All of above are alocated only once in init() and don't have free() calls.
>
> Is there a reason for that?
I fixed easy ones. Now I am waiting for decision about big in/out
buffers in fmt files.
Lukas
Download attachment "mem_alloc-fixes.diff" of type "application/octet-stream" (14153 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
