[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6zH4FgR58SXmBAUWE9Vsxd8-veOe-EOPaxAS9_CaQmweg@mail.gmail.com>
Date: Sun, 23 Dec 2012 19:39:57 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: scan-build results, part 1
On Sun, Dec 23, 2012 at 6:36 PM, Dhiru Kholia <dhiru.kholia@...il.com> wrote:
> scan-build is complaining about "Logic error Stack address stored into
> global variable" in single.c.
>
> 495 void do_single_crack(struct db_main *db)
> 496 {
> 497 struct rpp_context ctx;
> 498
> 499 single_db = db;
> 500 rule_ctx = &ctx;
> 501 single_init();
> 502 single_run();
> 503 single_done();
> 504 }
>
> Address of stack memory associated with local variable 'ctx' is still
> referred to by the global variable 'rule_ctx' upon returning to the
> caller. This will be a dangling reference.
>
> I don't know if rules_ctx's value is used later on or not.
For complete set of results, see
http://dl.dropbox.com/u/1522424/scan-build-2012-12-23-16.tar.bz2
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
