[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d0156aca3ff7e3afcdc1fff92f1ada7d@smtp.hushmail.com>
Date: Mon, 10 Dec 2012 07:46:26 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Self-test for split-unifies-case
On 10 Dec, 2012, at 4:16 , Dhiru Kholia <dhiru.kholia@...il.com> wrote:
> On Monday 10 December 2012 04:37 AM, magnum wrote:
>> Dhiru, all,
>>
>> I just added a self-test that fails if a format claims FMT_SPLIT_UNIFIES_CASE despite using fmt_default_split.
>>
>> Among CPU-only formats the following was immediately caught:
>>
>> $ ../run/john -t=0 | grep FAILED
>> Benchmarking: Clipperz SRP SHA256 [32/64 oSSL-exp]... FAILED (FMT_SPLIT_UNIFIES_CASE)
>> Benchmarking: Kerberos 5 AS-REQ Pre-Auth etype 17/18 aes-cts-hmac-sha1-96 [32/64]... FAILED (FMT_SPLIT_UNIFIES_CASE)
>> 2 out of 197 tests have FAILED
>>
>> One or more GPU formats will fail this too. Dhiru, I'll fix krb5pa (I'll need to fix the GPU format anyway) but you get to fix Clipperz.
>>
> Copy-paste fail on my part.
>
> Is simply removing FMT_SPLIT_UNIFIES_CASE a valid fix? I really don't need a split method which changes the case of ciphertext.
Only provided that valid() rejects uppercase hex. I think we have a variant of atoi16 for that somewhere.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
