[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d93158b8d866f046ba364daad3666268@smtp.hushmail.com>
Date: Sun, 18 Nov 2012 22:57:02 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: zsh completion for john
On 18 Nov, 2012, at 16:57 , Vlatko Kosturjak <kost@...ux.hr> wrote:
> Since I did not find any references regarding zsh completion for john,
> except this one:
> http://www.openwall.com/lists/john-dev/2012/05/23/2
>
> I've made one. Of course, I don't mind if you share it with john:
> https://github.com/kost/jtr-stuff/blob/master/zsh/_john
Great, see below.
> Also, I have found some incosistency in --list= command, so I've made
> small patch:
> https://github.com/magnumripper/JohnTheRipper/pull/108
The inconsistences were that is wrote to stderr (no other --list options do) and it had an extra heading for historical reasons. I accepted this pull request despite it might theoretically break things: NOTE! any scripts/programs depending on this might need to be adjusted. Perhaps Johnny the GUI is affected, I doubt there are any others in this case. Unless the Test Suite is... but I think it checks both stderr and stdout. I'll have a look at it right away.
> Actually what is the best method to submit patches? via github pull
> requests or sending here to the mailing list?
Some things (especially core changes) could/should be discussed on list first, perhaps with a patch (early, PoC or complete). With that said, I really appreciate pull requests. In fact, I would appreciate a pull request for your zsh completion, complete with whatever is needed (maybe a zsh-completion make target? Or maybe change the existing bash-completion make target to do both (new name shell-completion or something like that).
thanks,
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
