[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120920001445.GA25617@openwall.com>
Date: Thu, 20 Sep 2012 04:14:45 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: 1.7.9-jumbo-7
magnum, Jim, Claudio, Lukas -
On Wed, Sep 19, 2012 at 02:19:12AM +0200, magnum wrote:
> I hope all is well now.
Thank you! Here are a few more things I noticed:
dumb16.conf and dumb32.conf started to use cipher_limit, but it is not
defined anywhere. I'll drop these changes.
macosx-x86-64-gpu, macosx-x86-64-cuda targets have been added - do they
actually work?
alghmac.h change:
+#ifndef __APPLE__
#include <malloc.h>
+#endif
Wouldn't it be more correct to #include <stdlib.h> (on all platforms)
instead, or something like that? (Note: I did not review this in context.)
Please help me describe the changes to common-opencl.[ch] - what are the
additions? Do I say this is "better autodetection" or something? I'd
appreciate a properly worded paragraph describing this.
What's the "regen_lost_salts == 6" addition? "Support for regenerating
salts for Formspring's sha256($s.$p), known as $dynamic_61$, where $s is
two digits"?
The instances of:
#if ARCH_ALLOWS_UNALIGNED==1
should be changed to be simply:
#if ARCH_ALLOWS_UNALIGNED
Claudio - what has changed here (and with other related changes)? -
Only in 1.7.9-jumbo-6-fixes/src/opencl: cryptsha512_kernel_AMD.cl
Only in john-1.7.9-jumbo-6/src/opencl: cryptsha512_kernel_AMD_V1.cl
"Support for more varieties of PKZIP archives" - correct description?
"RAR: better early rejection (speedup)" - correct description?
Lukas, magnum - how come Lukas' phpass optimizations, which Lukas
extensively tested prior to CMIYC 2012 (in case we'd be given these
hashes in the contest), are not in the fixes branch? I'd like to add
them now.
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
