|
Message-ID: <CABob6irCJL0suegPEUSgcH_Bou2N7qg_tO5jKAc+xXVSEDQJ8A@mail.gmail.com> Date: Wed, 22 Aug 2012 23:37:17 +0200 From: Lukas Odzioba <lukas.odzioba@...il.com> To: john-dev@...ts.openwall.com Subject: Re: 32bit os warnings 2012/8/22 magnum <john.magnum@...hmail.com>: > Claudio has patched this in magnum-jumbo now. Do you get any warnings > when building the 1.7.9-jumbo-6-fixes branch? > > magnum > On 1.7.9-jumbo-6-fixes clean. On magnum-jumbo I am getting those: ukasz@...kstar:~/JtR/current/magnum-jumbo/src$ make linux-x86-opencl -j 1>/dev/null opencl_rawsha512-ng_fmt.c: In function 'get_partial_binary': opencl_rawsha512-ng_fmt.c:63: warning: left shift count >= width of type opencl_rawsha512-ng_fmt.c:63: warning: left shift count >= width of type opencl_rawsha512-ng_fmt.c:63: warning: right shift count >= width of type opencl_rawsha512-ng_fmt.c:63: warning: right shift count >= width of type Since on 32bit usually: sizeof(long)=4 sizeof(long long)=8 we can fix them by: return (SWAP64((unsigned long long)b[3]) - 0xa54ff53a5f1d36f1ULL); Or by defining b as unsigned long long instead of uint64_t which is unsigned long. With slackware14 release I am moving to 64bit os. I'll do some scripts to automagically catch similar issues after each commit in the future. This may help find bugs introduced by commits if script will run TS too. Lukas
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.