Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120818180642.GA29673@openwall.com>
Date: Sat, 18 Aug 2012 22:06:42 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: OSX 10.8 (GT 650M) build fail

magnum, myrice -

On Sat, Aug 18, 2012 at 07:58:08PM +0200, magnum wrote:
> On 2012-08-18 12:00, myrice wrote:
> > sed -n 's/^\(struct fmt_main [^ ]*\) =.*/extern \1;/p' *_fmt_plug.c >
> > fmt_externs.h
> > sed: RE error: illegal byte sequence

BTW, this means that we have 8-bit chars that are not part of valid
UTF-8 sequences in the *_fmt_plug.c files.  We might want to get rid of
those weird chars (likely iso-8859-1 in a contributor's name?)

> > It is osx 10.8 has strict sed. I add LANG=C to make macosx-x86-64-opencl
> > 
> > The interesting thing is, when I first run this command, the error
> > still there. But the second will be okay.
> 
> I added "LC_ALL = C" to Makefile a while ago to remedy this problem but
> apparently that was not the correct way to do it (I was shooting in the
> dark).

I think we shouldn't be changing these settings in the Makefile globally
unless we truly have to.  A better way may be to do this just for the
sed invocations, like this:

	LANG=C sed ...

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.