Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <502E39B1.2050305@semjanov.com>
Date: Fri, 17 Aug 2012 16:31:45 +0400
From: Pavel Semjanov <pavel@...janov.com>
To: john-dev@...ts.openwall.com
Subject: Re: RAR early reject

On 17.08.2012 8:04, magnum wrote:
> Milen,
>
> Thanks to JimF's pkzip code and some crucial hints from Pavel Semjanov,
> I finally nailed the early reject we wanted! Have a look at this:

You're welcome. However, I don't quite understand this code fragment:

if (plain[0] & 0x80) {
// PPM checks here.
if (!(plain[2] & 0x20) || // Reset bit must be set
(plain[2] & 0xc0) || // MaxOrder must be < 64
(plain[3] & 0x80)) // MaxMB must be < 128
goto bailOut;

Reset bit is placed in plain[0], isn't it? Why you're using plain[2]?

-- 

    SY / C4acT/\uBo             Pavel Semjanov
    _   _         _        http://www.semjanov.com
   | | |-| |_|_| |-|

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.