[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3cb38f86f9c63076d656651e442f2c1a@smtp.hushmail.com>
Date: Thu, 16 Aug 2012 22:52:46 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Serious wordlist.c bug fixed (all branches)
On 2012-08-15 06:09, jfoug wrote:
>> From: Solar Designer [mailto:solar@...nwall.com]
>> On Tue, Aug 14, 2012 at 10:15:09PM -0500, jfoug wrote:
>>> A good way to find these ugly problems, is with a debugging allocation
>> lib.
>>> The free will hammer the memory, before freeing it
>>
>> We can do this in the MEM_FREE() macro in memory.h in debugging builds,
>> ********and we need to be using this macro consistently. ********
>
> I agree with this line strongly. Many have been using strdup, malloc,
> realloc, free, etc. Also, there often are allocations being done, when
> there is no real need to do so. There are memory leaks in JtR, and tracking
> them down is not overly easy, with the multitude of different calls to
> different allocation functions.
I just committed a large-ish patch to magnum-jumbo that changes nearly
all uses of free() (as well as some macros) to MEM_FREE.
Dhiru, all, please use MEM_FREE from now on.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
