[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <006401cd7b0a$4adb0710$e0911530$@net>
Date: Wed, 15 Aug 2012 12:20:39 -0500
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: SRP
I have fixed the warnings, and added OMP. The change has been pushed to jumbo-bleeding (9c0169a).
OMP works fine for GMP. It also appears to be working for oSSL, however, the gain was a smaller percentage (and fluctuates). Also, the oSSL expmod testing was done with 1.0.1c which is new. I think others have said there may be oSSL OMP issues on older versions. I cannot say for sure on this one.
I wonder if we should change the name of this from wowsrp (and wow_srp_fmt_plug.c) to srp-wow (and srp_wow_fmt_plug.c), and then build a srp format (and srp_fmt_plug)? This would keep the name similar. It is 'SRP' algorithm, but with the battlenet specifics, vs the 'stock' SRP.
Jim.
>From: magnum [mailto:john.magnum@...hmail.com]
>
>On 2012-08-15 12:29, magnum wrote:
>> On 2012-08-15 08:06, jfoug@....net wrote:
>>> Here is a version (same as last, still 'battlenet' SRP), which can be
>>> compiled with no flags, and builds with oSSL's BN, or you can add
>>> -DHAVE_GMP to the CFLAGS, and add -lgmp to the LDFLAGS (and of course
>>> have libgmp installed), and it will build either way.
>
>I now added the HAVE_GMP to Makefile, default commented out.
>
>> I get the following benign warnings (using OpenSSL):
>>
>> wow_srp_fmt_plug.c: In function ‘crypt_all’:
>> wow_srp_fmt_plug.c:269:6: warning: unused variable ‘i’
>> [-Wunused-variable]
>> wow_srp_fmt_plug.c:268:39: warning: unused variable ‘p’
>> [-Wunused-variable]
>> wow_srp_fmt_plug.c:268:25: warning: unused variable ‘HashStr’
>> [-Wunused-variable]
>
>These are not present when building with gmp
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
