[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <224ed7b5271a2abe5f8f804f48c297f2@smtp.hushmail.com>
Date: Tue, 14 Aug 2012 22:40:31 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Serious bug in -fixes and all other branches
On 2012-08-14 20:42, jfoug wrote:
...
> I think this fixes all issues. Loader.c is left alone. We 'still'
> need to call the function to 're' HEX lines before being dumped out
> to the .pot file, however.
>
> But now, split, prepare and valid, all properly remove any HEX that
> is there. It is likely that the split functions are not needed to do
> this, but no harm is done by having the code there, it can only be
> removed once. So internally, there is no $HEX$ data. Externally we
> 'write' using $HEX$ when needed, and can read $HEX$ and remove it
> properly from input files, and from .pot files. I believe this
> should put this issue to bed.
Great!
> The hard part, is this is in valid, which is a function that has a
> different signature between J6-fixes, jumbo and bleeding. Magnum,
> how would you like me to proceed on bringing this patch forward?
I just merged all branches, no problem at all.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
