Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6wOU2xPh3wmrTzvJw-mAQdUQsk09dsHzr8X_Acy=5h-gQ@mail.gmail.com>
Date: Mon, 16 Jul 2012 15:26:07 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: hmacSHA*_fmt.c

On Mon, Jul 16, 2012 at 3:32 AM, magnum <john.magnum@...hmail.com> wrote:
> On 2012-06-29 08:13, Solar Designer wrote:
>> magnum -
>>
>> BTW, I find it illogical that we have OpenMP support in rawSHA224_fmt.c,
>> etc., but not in hmacSHA224_fmt.c, etc.
>>
>> Also, they accept mixed-case hexadecimal encodings, but don't unify them
>> in split() (nor set the flag).  This is a bug.  For comparison,
>> rawSHA1_fmt_plug.c does the unification, whereas rawSHA224_fmt.c, etc.
>> accept lowercase only.
>
> This has been on my to-do list since, but I can't find the time in weeks
> from now. The second issue (at least) should be fixed before J7. Anyone
> that wish to give it a shot is very welcome.

I can work on adding OpenMP support to hmacSHA224_fmt_plug.c etc. From
a cursory glance, it seems ipad, opad, crypt_key and  need saved_plain
to be arrays instead of variables? Correct?

-- 
Cheers,
Dhiru

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.