[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <008001cd6290$92298660$b67c9320$@net>
Date: Sun, 15 Jul 2012 08:48:52 -0500
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: Another CVS core bug: Does not load bare hashes
This may be better 'fixed' with a 1 line change in loader.c
In the bottom of the !ciphertext block:
}
*p = 0;
*login = no_username;
+ fields[1] = *ciphertext;
}
I am testing now, to be 100% sure this does fix 'everything', but I believe it will. This change will allow all formats to simply use fields[1] as the 'input', unless they look in other places, even if there IS no real field[1]. This was how things were prior to the new changes to prepare. I do not dig into core, but I would imagine the code may need to be changed there also.
Jim.
>-----Original Message-----
>From: jfoug [mailto:jfoug@....net]
>Sent: Sunday, July 15, 2012 8:30 AM
>To: john-dev@...ts.openwall.com
>Subject: RE: [john-dev] Another CVS core bug: Does not load bare hashes
>
>>From: magnum [mailto:john.magnum@...hmail.com]
>>Sent: Sunday, July 15, 2012 4:37 AM
>>To: john-dev@...ts.openwall.com
>>Subject: [john-dev] Another CVS core bug: Does not load bare hashes
>>
>>Solar,
>>
>>I believe current CVS core does not load bare hashes. Specifically, the
>>CVS core build does not load bare DES and my merged temporary bleeding
>>branch does not load bare raw-md5u ones. I will just ignore this until
>>fixed in core.
>
>This is due to a change in prepare. Actually, it may be due to a change
>in loader, but I think it should be changed in each format's prepare
>statement, since they can get their data from any field.
>
>Before, I think the code would put field 0 into field 1, if there was
>only 1 field. I made this simple change to dyanamic's prepare, and
>things work fine for it.
>
> char *cpBuilding=split_fields[1];
>+ if (!cpBuilding || *cpBuilding==0)
>+ cpBuilding = split_fields[0];
>
>So I will see if there are other formats which a 'raw' fails the TS, and
>make changes where they need to be made.
>
>But that bug should be easy to squash.
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
