Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c0ec900edb8230f4b918ddf00c57285@smtp.hushmail.com>
Date: Tue, 10 Jul 2012 00:51:25 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: magnum-jumbo and magnum-bleeding (NOT J7), and the
 source() function

On 2012-07-10 00:46, jfoug wrote:
> I do think the interface for source() (or get_source(), or foo_bar() or
> whatever) is good.   Passing in the db_password structure pointer, and then
> 'using' the salt pointer in multiple ways, makes calling source() very easy
> to do, almost a direct replacement for the original pw->source pointer, AND
> saves memory, in not wasting space even for another pointer. Also, passing
> in the buffer is pretty much needed, since that allows this function to be
> called from multi-threaded code.  I am not 'sure' it will be called from MT
> code, but it certainly could be.

We have seen some need for also passing the index though. This is
currently worked around in the linkedin format, by looping to mkpc and
finding out what index we want. Would this be tricky to change?

magnum


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.