|
Message-ID: <1341478263.72787.YahooMailNeo@web161303.mail.bf1.yahoo.com>
Date: Thu, 5 Jul 2012 01:51:03 -0700 (PDT)
From: deepika dutta <deepikadutta_19@...oo.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: mschapv2 conversion
Finally, after a long struggle with the code Igot the test suite working :)
Actually as suggested by solar previously, that in mschapv2_crypt_all() we should
put MD4 and setup_des_key() both in key_prepared flag to prevent
recomputation of setup_des_key() , I did that change. Now since in cmp_exact() the key is set again to new value (which I am doing in index 0) therefore the value of des_bs_all.K changes (for index 0) and because for
next plaintext in crypt_all() we do not do setup_des_key(), therefore
des_bs_all.K (at index 0) is not set to correct value.
So what I have done now is that in cmp_exact() of mschapv2 before we return, i call setup_des_key() once again only for setting the key for index 0 which sets the keys to correct value.
I will upload the patch soon...
Cheers,
Deepika
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.