Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP867B76572C059146526CF4FDEF0@phx.gbl>
Date: Fri, 6 Jul 2012 00:42:24 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Would supporting ./john --help be a good idea?

On 07/05/2012 11:40 PM, magnum wrote:
> On 2012-07-05 21:19, Frank Dittrich wrote:
>> What's wrong with deleting those two lines from opt_init(), and adding
>> print_usage to  john_init()?
> 
> Try that, it sounds good but you never know what hits the fan. If it
> seems to work fine, it just might work fine :)

I'll need to move quite some code from options.c to john.c, so the patch
might be difficult to review (and jumbo diverges even more from core,
but other than that, I see no problem.
(I did, however, not even start with that change.)
If I don't move all the code that is needed only for print_usage from
options.c to john.c, then the only caller of print_usage() would be in a
different file than the definition...

Frank


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.