[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP105089A41C09D4BAE3751E4FDEF0@phx.gbl>
Date: Thu, 5 Jul 2012 21:19:50 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Would supporting ./john --help be a good idea?
On 07/05/2012 09:08 PM, Frank Dittrich wrote:
> This needs to be changed:
>
> options.c:289: if (argc < 2)
> options.c-290- print_usage(name);
>
> And this as well:
>
> john.c:558: if (argc < 2)
> john.c-559- john_register_all(); /* for printing by opt_init() */
>
> But I'd hate to make the same change in two different places.
> Would a new global variable be OK, a new parameter for opt_init(), or
> should I make john_register_all known in options.c, and call it inside
> print_usage()?
Stupid me.
What's wrong with deleting those two lines from opt_init(), and adding
print_usage to john_init()?
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
