[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6zGJ0O4SbU-beOq=WDtx8Jd0uz65KzWrT+wT6zcw1S=FQ@mail.gmail.com>
Date: Wed, 27 Jun 2012 15:04:39 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: SSH format crashes when built using "linux-x86-clang-debug"
On Wed, Jun 27, 2012 at 2:57 PM, Dhiru Kholia <dhiru.kholia@...il.com> wrote:
> The actual size of "static struct custom_salt cs" might be less than
> defined SALT_SIZE. Will this cause a problem? It this the cause behind
> the crashes?
>
> The following patch fixes the problem (at least on my machine),
>
> diff --git a/src/ssh_fmt.c b/src/ssh_fmt.c
> index b26fa9a..bf0d161 100644
> --- a/src/ssh_fmt.c
> +++ b/src/ssh_fmt.c
> @@ -40,7 +40,7 @@
> #define BENCHMARK_LENGTH -1001
> #define PLAINTEXT_LENGTH 32
> #define BINARY_SIZE 0
> -#define SALT_SIZE 4224
> +#define SALT_SIZE sizeof(struct custom_salt)
> #define MIN_KEYS_PER_CRYPT 1
> #define MAX_KEYS_PER_CRYPT 1
magnum,
Can you please commit the attached patch to magnum-jumbo (along with
the patch Solar posted). Thanks!
--
Cheers,
Dhiru
Download attachment "0001-Fix-salt-size-in-SSH-format.patch" of type "application/octet-stream" (669 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
