[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120623190744.GA689@openwall.com>
Date: Sat, 23 Jun 2012 23:07:44 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Several enhancements for relbench
Frank -
On Sat, Jun 23, 2012 at 07:17:50PM +0200, Frank Dittrich wrote:
> If a particular benchmark appears several times in the same file,
> print a message to STDERR,
OK.
> and pick the higher values for
> comparision (higher real value is considered here, only if the
> real values are the same, the higher virtual value is considered).
I think it's better to include ALGORITHM_NAME into the names being
compared (for both formats) when an otherwise-matching format name is
detected. Only if that still leaves matching format names, print a
second warning and do something else (like what you implemented).
There should also be logic to include ALGORITHM_NAME into the name of a
third format that would otherwise match the first two (before
ALGORITHM_NAME was added to them). For example, if we have:
format [alg1]
format [alg2]
format [alg3]
format [alg2]
format [alg3]
format [alg1]
Then merely changing to:
format [alg1]
format [alg2]
format
format [alg2]
format [alg3]
format
would be wrong as it'd result in a direct comparison of alg3 vs. alg1
results. Instead, we should keep/include algorithm names in all three
formats in that case.
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
