[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP14676F0C1B1F35203223641FDFC0@phx.gbl>
Date: Fri, 22 Jun 2012 09:04:32 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Re: EPiServer format fails on 32-bit builds.
On 06/22/2012 07:57 AM, Dhiru Kholia wrote:
> On Thu, Jun 21, 2012 at 9:38 PM, Dhiru Kholia <dhiru.kholia@...il.com> wrote:
>> When I test the episerver format using the attached patch, I get
>>
>> ../run/john -format=episerver -t
>> FAILED (get_hash[1](0))
>
> This bug is now hopefully fixed. Please pull and test. Thanks!
OK, the test now passes.
But a base64 encoded string of length 24 decodes to 24 / 4 * 3 = 18.
So I wonder if you shouldn't use unsigned char esalt[18] instead of
unsigned char esalt[16+1], and add an appropriate comment in the source
code.
But may be the encoded salt will always end with ==, I don't know the
format.
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
