Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120620161154.GA21372@openwall.com>
Date: Wed, 20 Jun 2012 20:11:54 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: EPiServer

Dhiru -

On Wed, Jun 20, 2012 at 12:54:51PM +0530, Dhiru Kholia wrote:
> On Tue, Jun 19, 2012 at 2:12 AM, Solar Designer <solar@...nwall.com> wrote:
> > episerver_fmt_plug.c supports both the SHA-1 and the SHA-256 based
> > flavor of these hashes, however the test vectors are only for SHA-1.
> >
> > This needs to be corrected.  Since it will affect benchmark speeds,
> > we'll need to reflect the number of test vectors of each type in the
> > benchmark comment.
> 
> SHA-256 code is speculative (it might be totally useless). I could not
> get my installation of EPiServer to use SHA-256 hashes, so I don't
> have any samples to work with. I can remove the code if needed.

Please keep the code, but add a comment explaining that the code is
speculative.

Maybe you can ask Per for sample hashes?

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.