Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120617160511.GO31349@cmpxchg8b.com>
Date: Sun, 17 Jun 2012 18:05:11 +0200
From: Tavis Ormandy <taviso@...xchg8b.com>
To: john-dev@...ts.openwall.com
Subject: Re: Re: [patch] optional new raw sha1 implemetation

On Sun, Jun 17, 2012 at 05:28:02PM +0200, magnum wrote:
> On 2012-06-17 17:11, magnum wrote:
> >It's gone again anyway, Tavis reverted to defining _GNU_SOURCE and using
> >memrchr. Will this work on *BSD? I have no idea. For a Sparc it's no
> >issue since the format won't be included anyway.
> 
> Tavis, I just got this report off-list:
> 
> Undefined symbols for architecture x86_64:
>   "_memrchr", referenced from:
>       _sha1_fmt_get_key in taviso_fmt.o
>       _sha1_fmt_cmp_one in taviso_fmt.o
> ld: symbol(s) not found for architecture x86_64
> collect2: ld returned 1 exit status
> make[1]: *** [../run/john] Error 1
> make: *** [macosx-x86-64] Error 2
> 
> ...so I think you really need to ditch that memrchr (or write your
> own, it's trivial).
> 
> magnum

Okay, I can live with strrchr. I sent you that change.

Tavis.

-- 
-------------------------------------
taviso@...xchg8b.com | pgp encrypted mail preferred
-------------------------------------------------------

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.