[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120516235532.GA17672@openwall.com>
Date: Thu, 17 May 2012 03:55:32 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: mschapv2-conversion
Deepika -
On Wed, May 16, 2012 at 01:56:21PM -0700, deepika dutta wrote:
> 5. In DES_bs_b.c, DES_bs_crypt_one() function is added.
>
> I have not completed the conversion fully but was testing for fmt_self_test() which should be able to encrypt using DES_bs_crypt_one() but it terminates on reaching S1(....). I have attached the source files, where sections marked CHANGE are the changes I have done.
Despite of my previous response, I took a quick look.
In DES_bs_crypt_one(), you set:
k = DES_bs_all.KS.v;
I think it should be:
k = DES_bs_all.KS.p;
to match DES_bs_crypt_LM() in this aspect, because that's the quicker
approach when there are no iterations and that's what you should be
initializing for (I haven't checked whether you actually do).
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
