[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+TsHUBMUwO4Cid3bPn6TpNtAAvPknvps0KwDk+dz7OWPXd+aA@mail.gmail.com>
Date: Fri, 13 Apr 2012 16:23:27 +0530
From: SAYANTAN DATTA <std2048@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: MSCash2 OpenCL (was: OpenCL tests on HD 7970)
On Thu, Apr 12, 2012 at 3:12 AM, Solar Designer <solar@...nwall.com> wrote:
> Also, please start cleaning up your code - as separate patches. Please
> do not include any functional changes or optimizations in those patches,
> limit them just to code cleanups. (Generate separate patches for the
> functional changes and optimizations.) You may use this indent command
> to format your source files:
>
> indent -kr -i8 -nlp -nbbo -ncs -l79 -lc79
>
> Please note that indent fails on our struct fmt_main initializers (it
> indents them in a weird way). So please only run indent on your files
> once, then re-format the struct fmt_main initializer manually (look at
> the one in DES_fmt.c as a sample of desirable indentation), and from
> that point on just be careful with further edits to keep them in the
> same style.
>
> Besides indentation, you may want to make other kinds of cleanups as
> well. For example, you have many functions that are not declared
> static, yet are probably only meant for use from the same source file -
> you need to declare them static to avoid accidental use from elsewhere.
>
As you told I have indented the code , added some missing memory cleanups
and added static specifier for functions and variables meant to be used
within the source.
commit:b8e719329
Regards,
Sayantan
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
