[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6yeHqrJv=Z6OYwL2f5ASVD+fvku_avSeOt2fgxHD_PvHA@mail.gmail.com>
Date: Thu, 12 Apr 2012 20:47:11 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: PDF format
On Sun, Mar 25, 2012 at 6:47 PM, <jfoug@....net> wrote:
> The logic in get_salt() and set_salt() should be reversed.
>
> Within pdf (and a few other formats), a lot of time is spent within the set_salt function, parsing, allocating, setting up a complex structure. This type of work should NOT be done within the runtime loop. If done in set_key(), then it is in the runtime loop, and each salt computation will be done for EACH salt for EACH password (block of pw's) attempted. This time spent in set_salt() will GREATLY slow down the format.
> If this same logic is moved to get_salt(), then it will be done ONE time, for each salt, at the load time of john. There will be no runtime penalty for a 'complex' salt.
This is now done and committed to magnum-jumbo. However "many salts"
case is still slower than "one salt" case. Is this due to
initPDFCrack function being called from set_salt?
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
