Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6z_AYAYPv=kN6uQGV9FaHhym=ME4Q1TORKHb36r4hC1uQ@mail.gmail.com>
Date: Mon, 26 Mar 2012 13:56:46 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: [JtR patch] Fast cracker for Mozilla Firefox,
 Thunderbird and SeaMonkey master passwords.

On Mon, Mar 26, 2012 at 1:48 PM, magnum <john.magnum@...hmail.com> wrote:
> Because that buffer overrun of globalSalt overwrites the fd! So you are
> calling fseek with a trashed file descriptor.
>
> I suppose it should be globalSalt[25] now. I see from the comments it
> has grown over time (with newer versions of Mozilla) from 16 but they
> forgot to bump the size in the struct.

Cool, understood. Can you commit the fixed version?

Also, the speed of the format has gone down since my first release (is
it due to moving of memcpy to crypt_all which is required for OMP
support?).

-- 
Cheers,
Dhiru

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.