Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cc903a8297e0197c9ffddc894128febf@smtp.hushmail.com>
Date: Sun, 25 Mar 2012 20:23:26 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: [JtR patch] Fast cracker for Mozilla Firefox, Thunderbird
 and SeaMonkey master passwords.

On 03/25/2012 04:34 PM, Dhiru Kholia wrote:
> On Sun, Mar 25, 2012 at 7:49 PM, Dhiru Kholia <dhiru.kholia@...il.com> wrote:
>> I ran "indent -kr -i8 -nlp -nbbo -l120 -lc120" on mozilla_des.c,
>> leading to generation of those braces. heh, didn't knew that indent
>> could change the source so dramatically. I am reverting the source
>> back to original.
> 
> Hi magnum,
> 
> I have committed the original mozilla_des.c (no indent this time).
> However, the compiler warnings are back. Can you take a look?

The braces came from my patch, not from indent. A proper fix is the one
Solar suggested, using unions. Or we can just live with the warnings.

magnum


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.