Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <94511205d6a9afe150223f02a3c59dcf@smtp.hushmail.com>
Date: Wed, 15 Feb 2012 22:34:13 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Was:  RE: [john-users] sha1 + hex salt

On 02/15/2012 05:16 PM, jfoug wrote:
> I have made changes to the dynamic format.  The const values were 100% using
> memcpy type stuff, and a length value along with them. However, when loading
> a format, it used 
> 
> curdat.Consts[curdat.nConsts] = (unsigned
> char*)str_alloc_copy(Setup->pConstants[curdat.nConsts].Const);
> curdat.ConstsLen[curdat.nConsts] =
> strlen(Setup->pConstants[curdat.nConsts].Const);
> 
> The str_alloc_copy, and the strlen, kind of blew the keeping of the
> length's, and using memcpy's, lol.
> 
> I will get a patch out after I get a little more testing done.  Things are
> working, but I want to make sure test suite still is happy with these
> changes.

Patch was sent to me and committed to the git branches.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.