[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120120131454.GA5525@openwall.com>
Date: Fri, 20 Jan 2012 17:14:54 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: getting the CUDA & OpenCL stuff into -jumbo
Lukas -
On Thu, Jan 19, 2012 at 11:45:06AM +0100, Lukas Odzioba wrote:
> 2012/1/19 Solar Designer <solar@...nwall.com>:
> > I notice that e.g. in john-1.7.9-jumbo-5-opencl-4-final.diff the formats
> > only define 3 or 5 of the 7 binary_hash*() and get_hash*() functions.
> > The missing functions for larger hash tables are needed for scalability
> > to larger numbers of hashes loaded for cracking simultaneously. Can you
> > please get these added?
>
> Thanks for looking at code, I'll add them.
Thanks for doing it.
The *_hash_6() functions in john-1.7.9-jumbo-5-opencl-4.1.diff are
incorrect. The masks should be 0x7ffffff (27 bits), not 0xfffffff
(28 bits). The rest are OK (for smaller hash tables).
Please correct this. Also, I think you don't actually need minor
version numbers on updates to these patches - e.g., I think you should
have used -5 instead of -4-final, then -6 instead of -4.1, etc.
So instead of -4.2, just use -5 now.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
