[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ED54C8E.9080800@hushmail.com>
Date: Tue, 29 Nov 2011 22:20:14 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: .bss size in -jumbo
2011-11-29 21:10, jfoug wrote:
> I did not add any 'memset' after allocations on the changes magnum has made.
> Like I said, it 'may' not be an issue anywhere. However, the md5 std format
> caused one of my builds to core, due to not memsetting the buffer to start
> with, and then a strlen() call was returning a HUGE string. Skipping memset
> on these formats 'may be' safe, but who knows.
I admit not being 100% sure, but I opted to memset only where I believe
it's needed. The sapG and sapB formats got memsets, the rest should be
fine without it.
On the other hand, the NET*LM* and mskrb5 formats has actual size chosen
from number of slots in use, so memsetting would not mean wasted memory.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
