Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <03fe01ccaed2$fd233550$f7699ff0$@net>
Date: Tue, 29 Nov 2011 14:10:49 -0600
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: .bss size in -jumbo

>From: magnum [mailto:john.magnum@...hmail.com]
>
>Nine of the worst offenders are fixed in patch 0019. I did the ones I
>was guilty of :)

I added code for crc32, mscash1, XSHA512.  Those were the other 3 formats on
Solars 'bad-list' for .bss size on OMP builds.

I did not add any 'memset' after allocations on the changes magnum has made.
Like I said, it 'may' not be an issue anywhere.  However, the md5 std format
caused one of my builds to core, due to not memsetting the buffer to start
with, and then a strlen() call was returning a HUGE string.  Skipping memset
on these formats 'may be' safe, but who knows.

Jim.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.