[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4EC4D220.7030301@banquise.net>
Date: Thu, 17 Nov 2011 10:21:36 +0100
From: Simon Marechal <simon@...quise.net>
To: john-dev@...ts.openwall.com
Subject: Re: hmacMD5 and sse-intrisics.c (Bartavelle, please look
at this).
On 16/11/2011 22:14, jfoug wrote:
> I have put a patch on the wiki, but I really want Simon/Bartavelle to have a look to make sure things are correct. I have not tested MD4, but I would be very surprised if that code did not also require the same type change.
I did not test it, but it looks fine to me. I'm not sure why the code
was in such a state in the first place. I have not looked at it for so
long that it is all out of my head now ...
> If init==1 or init==0, then keep same logic. This will keep all existing code working 100% same as it is today.
>
> If init==2, then init the base vector from 'defaults'. However, write data to out in input format (64 byte interleaved buffers).
> If init==3, then init the base vector from the out pointer, but out is in input format. Also in this mode, we write to out, but do so in input format (64 byte interleaved buffers).
This is probably what you intend to do, but I suppose using #define'd
flags would clarify things a lot.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
