[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <009701cc6824$e8abdb30$ba039190$@net>
Date: Wed, 31 Aug 2011 16:28:21 -0500
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: log_event taking care of business (was: Outputting proper john.conf file name upon error)
Good ideas. I have added this as a wish list item (listed under
--verbose=x) and it links back to your original post.
>From: magnum [mailto:rawsmooth@...dband.net]
>
>Speaking of logging and verbosity: LOTS of places all over john look
>just like this:
>
>if (conditions) {
> log_event("! Warning message %d: %.100s", this, that);
>#ifdef HAVE_MPI
> if (mpi_id == 0)
>#endif
> fprintf(stderr, "Warning message %d: %.100s\n", this, that);
>}
>
>What if all those places were made more like this:
>
>if (conditions)
> log_event(LOGLEVEL_WARNING, LOG_MPI_ROOT,
> "! Warning message %d: %.100s", this, that);
>
>We should also have a new command line argument --verbosity=N that sets
>options.verbosity (or just --verbosity, no argument, bumps it by one).
>
>In logger.c, the log_event function should take care of the rest:
> * If options.verbosity >= loglevel, print as well as log.
> * Under MPI and if log_mpi_root is non-NULL, only print if mpi_id == 0
>
>However this is *not* for Jumbo-6 :-)
>
>magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
