Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110608163251.GA29010@openwall.com>
Date: Wed, 8 Jun 2011 20:32:51 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: 1.7.7-jumbo-6

On Wed, Jun 08, 2011 at 12:22:20AM -0500, JFoug wrote:
> Got warnings about strtok_r  on Mingw.  I doubt the thread safe stuff is in 
> there.  I will get this 'patched', it is trivial.  But I am wondering if 
> that is a function which again, is going to cause porting headaches, like 
> the strnlen ?

strtok_r() is slightly more portable than strnlen(), but, yes, it
reduces portability of JtR overall.  Since those uses of strtok_r() were
not justified (other than by the general wisdom that strtok() is bad),
I've simply replaced them to strtok().

> Link errors.

I've merged Jim's patch for those.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.