Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BANLkTi=Xq3bJXUU==xQ-rv3eYqc86c2u1A@mail.gmail.com>
Date: Tue, 7 Jun 2011 21:10:56 -0700
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: 1.7.7-jumbo-6

On Tue, Jun 7, 2011 at 8:57 PM, Solar Designer <solar@...nwall.com> wrote:
> This one refers to p0.rar, which is not there.  So perhaps it's of no
> use in the jumbo tree.  Should I remove it?

Sure, Go ahead with its removal. All *dump files are temporary files
created during my own testing. They can be recreated very easily.

> Anyway, it let me detect a problem:
>
> $ ./john ../src/unused/rardump
> Loaded 1 password hash (rar [32/64])
> ! p0.rar : No such file or directory
> Segmentation fault
>
> So I introduced "error();" (which terminates the program) right after
> the fprintf().  Sounds OK?

Oops, that return should have been exit(). The fix sounds good.

> And here's a trickier problem:
>
> $ ./john ../src/unused/sshdump
> Loaded 2 password hashes with 2 different salts (ssh [32/64])
> *** glibc detected *** double free or corruption (!prev): 0x000000001f5e0410 ***
> Aborted
>
> I don't yet know if it's a bug I introduced or if it was in your patch.
> Does -RC3 work on sshdump for you?

The RC3 works fine for me here.

$ rm ../run/john.pot ; ../run/john unused/sshdump
Loaded 2 password hashes with 2 different salts (ssh [32/64])
12345            (rsa_test.key)
12345            (dsa_test.key)

without any problems. (even runs fine under valgrind).

-- 
Cheers,
Dhiru

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.