[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110316020530.GA6929@openwall.com>
Date: Wed, 16 Mar 2011 05:05:30 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Speedup of x86 .S build of raw-sha1 format
Jim,
On Tue, Mar 15, 2011 at 05:28:25PM -0500, jfoug wrote:
> - memset(saved_key, 0, sizeof(saved_key));
> + //memset(saved_key, 0, sizeof(saved_key));
> + memset(saved_key, 0, 64*MMX_COEF);
To "make sure" it is sufficient to clean the smaller portion of
saved_key only, you could want to fill the rest of it with some
non-zero value, like:
memset(saved_key, 0x55, sizeof(saved_key));
memset(saved_key, 0, 64*MMX_COEF);
(use both of these at once). Then make sure JtR still works fine
(albeit slowly).
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
