oss-security - Re: Re: CVE-2009-1265 kernel: af_rose/x25: Sanity check the maximum user frame size

Openwall Project		/home Owl JtR Pro crypt pam_passwdqc tcb phpass scanlogd popa3d msulogin / Linux BIND / advisories presentations / services donations / wordlists passwords / NEWS community lists Wiki CVSweb mirrors signatures
bringing security into open environments

Password Recovery Resources on the Net

[<prev] [next>] [<thread-prev] [thread-next>] [month] [year] [list]

Date: Thu, 23 Apr 2009 14:54:06 +0800
From: Eugene Teo <eugene@...hat.com>
To: oss-security@...ts.openwall.com
CC: Willy Tarreau <w@....eu>
Subject: Re: Re: CVE-2009-1265 kernel: af_rose/x25: Sanity
 check the maximum user frame size

Willy Tarreau wrote:
> Hi Eugene,
> 
> On Wed, Apr 08, 2009 at 03:58:55PM +0800, Eugene Teo wrote:
>> {nr,rose,x25}_sendmsg() functions need to have sanity checks on the
>> packet size, otherwise the sizes can wrap and end up sending garbage.
>>
>> http://bugzilla.kernel.org/show_bug.cgi?id=10423
>> http://git.kernel.org/linus/83e0bbcbe2145f160fbaa109b0439dae7f4a38a9
>> http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2009-1265
>>
>> This affects both 2.4.x and 2.6.x if CONFIG_{NETROM,ROSE,X25} are enabled.
> 
> I already have it in my queue, just did not have time to merge it yet.
> Thanks for the reminder anyway, I really appreciate it ;-)

You will need this too :)

upstream commit: cc29c70dd581f85ee7a3e7980fb031f90b90a2ab

Patch "af_rose/x25: Sanity check the maximum user frame size"
(commit 83e0bbcbe2145f160fbaa109b0439dae7f4a38a9) from Alan Cox got
locking wrong. If we bail out due to user frame size being too large,
we must unlock the socket beforehand.

Thanks, Eugene
-- 
Eugene Teo / Red Hat Security Response Team

Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.