[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170816132425.GV1627@brightrain.aerifal.cx>
Date: Wed, 16 Aug 2017 09:24:25 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] syslog.h: fix warning "initialization discards
'const' qualifier from pointer target type"
On Wed, Aug 16, 2017 at 11:18:37AM +0200, Denys Vlasenko wrote:
> This happens when syslog.h is included with "#define SYSLOG_NAMES 1"
>
> Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>
> CC: musl@...ts.openwall.com
> ---
> include/syslog.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/syslog.h b/include/syslog.h
> index 5b4d296..25eb3e4 100644
> --- a/include/syslog.h
> +++ b/include/syslog.h
> @@ -70,7 +70,7 @@ void vsyslog (int, const char *, va_list);
> #define INTERNAL_NOPRI 0x10
> #define INTERNAL_MARK (LOG_NFACILITIES<<3)
> typedef struct {
> - char *c_name;
> + const char *c_name;
> int c_val;
> } CODE;
> #define prioritynames ((CODE *)(const CODE []){ \
> --
> 2.9.2
This is not the right fix; it changes the type of a struct member
that's a public interface and thereby invalidates correct code that
was using it.
The cause is a bug (#61579) in GCC whereby -Wwrite-strings changes the
language semantics (changes the type of string literals) rather than
just generating a warning. Removing this option will fix it.
However there are other reasons that having the names done with a
compound literal rather than an external symbol is a bad idea (and
contributing significant size waste to busybox, IIRC), and I suspect
the right fix will make your problem go away too.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
