[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Nov 2017 08:15:40 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Network Development <netdev@...r.kernel.org>,
David Miller <davem@...emloft.net>,
"kernel-hardening@...ts.openwall.com"
<kernel-hardening@...ts.openwall.com>,
"Jason A. Donenfeld" <Jason@...c4.com>, Theodore Ts'o <tytso@....edu>,
Kees Cook <keescook@...omium.org>, Paolo Bonzini <pbonzini@...hat.com>,
Tycho Andersen <tycho@...ker.com>, "Roberts,
William C" <william.c.roberts@...el.com>, Tejun Heo <tj@...nel.org>,
Jordan Glover <Golden_Miller83@...tonmail.ch>,
Greg KH <gregkh@...uxfoundation.org>, Petr Mladek <pmladek@...e.com>,
Joe Perches <joe@...ches.com>, Ian Campbell <ijc@...lion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <wilal.deacon@....com>, Steven Rostedt <rostedt@...dmis.org>,
Chris Fries <cfries@...gle.com>, Dave Weinstein <olorin@...gle.com>,
Daniel Micay <danielmicay@...il.com>, Djalal Harouni <tixxdz@...il.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] scripts: add leaking_addresses.pl
On Mon, Nov 06, 2017 at 09:41:09AM -0800, Linus Torvalds wrote:
> On Mon, Nov 6, 2017 at 9:27 AM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > Lovely. This is great. It shows just how much totally pointless stuff
> > we leak, and to normal users that really shouldn't need it.
>
> Side note: it would be good to have some summary view, and perhaps
> some way to limit duplicates.
This has been bothering me also.
> I ended up running this command line from hell to summarize the
> different sources:
>
> perl leaking_addresses.pl |
> cut -d: -f1 |
> sed 's:/[0-9]*/:/X/:g' |
> sed 's:/module/[^/]*/:/module/X/:g' |
> sort | uniq | less -S
>
> and maybe that kind of duplicate culling could be part of the script
> itself if you pass it some summary line.
>
> In particular, if would be nice to have a summary report that
>
> - only shows the first address for a particular source
>
> - have some logic to collapse repeated entries of "same file, just
> different instance"
>
> my sed-invocations there are obviously very ad-hoc, I'm not actually
> advocating that crap, it's only meant as hacky example of what I'm
> talking about. Something smarter would be much better.
>
> Because right now if some developer runs it, they might miss some case
> that they should care about, simply because it's hidden among all the
> thousands of essentially duplicate cases.
Awesome. I'm on it. thanks.
So, cull duplicates by default, add summary report to end of output, add
'--raw' option to dump all the lines (the current output).
thanks,
Tobin.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
